ENG-97 Try/Catch around more of the onYouTubeIframeAPIReady code to retry #1370
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-97 Try to fix continuing cases of window.onYouTubeIframeAPIReady.resolve is not a function and retry the full function
bryanlandia
changed the title
|
Checking git merge conflicts against https://github.com/edx/edx-platform.git
|
amirtds
approved these changes
Sep 13, 2023
bryanlandia
added a commit
that referenced
this pull request
Sep 15, 2023
…y-yt-api-errs ENG-97 Try/Catch around more of the onYouTubeIframeAPIReady code to retry ## Change description > Description here ## Type of change - [ ] Bug fix (fixes an issue) - [ ] New feature (adds functionality) ## Related issues > Fix [#1]() ## Checklists ### Development - [ ] Lint rules pass locally - [ ] Application changes have been tested thoroughly - [ ] Automated tests covering modified code pass ### Security - [ ] Security impact of change has been considered - [ ] Code follows company security practices and guidelines ### Code review - [ ] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary - [ ] "Ready for review" label attached and reviewers assigned - [ ] Changes have been reviewed by at least one other contributor - [ ] Pull request linked to task tracker where applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Still getting onYouTubeIframeAPIReady TypeErrors once in a while when loading YouTube videos in courseware.
When I reproduced it, I didn't see any of the JS console messages that I put in, like
so the try/catch I put in to retry the function wasn’t getting executed at least in this case.
This PR:
Type of change
Related issues
https://appsembler.atlassian.net/browse/ENG-97
Checklists
Development
Security
Code review